Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrent Experience Replay #34

Open
smorad opened this issue Nov 20, 2022 · 3 comments
Open

Recurrent Experience Replay #34

smorad opened this issue Nov 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@smorad
Copy link

smorad commented Nov 20, 2022

Is your feature request related to a problem? Please describe.

It seems that the implemented replay buffers only operate over transitions, with no ability to operate over entire sequences. This prevents the use of recurrent policies for tackling POMDPs.

Describe the solution you'd like

A SequenceReplayBuffer that returns contiguous episodes instead of shuffled transitions.

Describe alternatives you've considered

Additional context

@smorad smorad added the enhancement New feature or request label Nov 20, 2022
@KristianHolsheimer
Copy link
Contributor

Thanks, that's a very good suggestion. It's definitely been on mind.

I'm thinking of having a reward tracer that does something similar to what the frame stacking wrapper does. The idea is to stack entire transitions rather than only the observations. As long as we ensure to only create shallow copies (i.e. not copying the actual numpy arrays), I think we could keep this fairly lightweight and simple.

What do you think?

@frederikschubert
Copy link
Collaborator

You can also achieve something via the record_extra_info of the NStep reward tracer. Its a little besides the point but will give you the n observations, actions, etc. that follows a sampled observation.

@smorad
Copy link
Author

smorad commented Nov 21, 2022

I don't actually know enough about the architecture to provide good advice. I just found the design of coax really clean, and was considering porting some of my models to the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants