Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chokes on vim swap files #31

Closed
durka opened this issue Nov 7, 2015 · 5 comments
Closed

Chokes on vim swap files #31

durka opened this issue Nov 7, 2015 · 5 comments

Comments

@durka
Copy link
Contributor

durka commented Nov 7, 2015

If I don't delete *.swp before running cobalt build, it sometimes dies saying there is invalid UTF-8 in a file. Probably, it should either skip non-UTF-8 files (and emit a warning), or know how to skip common editor swap files.

@johannhof
Copy link
Contributor

Hi there, thanks for reporting!

I would actually say we need both functionalities. It shouldn't crash on invalid UTF-8 but maybe just skip the file with a warning. (We'd have to ramp up the error handling system for that).

We should also provide an --ignore flag (which could also be a .cobalt.yml option later) that could be passed a list of file endings to not copy.

I would recommend doing the latter option first. It shouldn't be too hard. If you want to give it a shot, I'd be happy to support you.

@durka
Copy link
Contributor Author

durka commented Nov 7, 2015

See my other PR for a small ramp-up of the error handling system :)

@durka
Copy link
Contributor Author

durka commented Nov 7, 2015

Hmm, I see it already skips dotfiles, so vim's .post.md.swp shouldn't be a problem... now I need to figure out which files it was crashing on before. It was fixed by deleting *.swp so there is something strange going on.

@durka
Copy link
Contributor Author

durka commented Nov 7, 2015

Aha, it doesn't skip dotfiles in the layout directory! That's the bug, I think.

@durka
Copy link
Contributor Author

durka commented Nov 7, 2015

See new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants