Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[convert-jekyll] define excerpt separator as option #375

Closed
Geobert opened this issue Jan 28, 2018 · 6 comments
Closed

[convert-jekyll] define excerpt separator as option #375

Geobert opened this issue Jan 28, 2018 · 6 comments

Comments

@Geobert
Copy link
Contributor

Geobert commented Jan 28, 2018

I know my use case is special, as it's WP -> Jekyll -> Cobalt but all the posts I convert uses <!-- more --> as separator. But I'd like to use the default separator for new posts.

So maybe allow option to define the separator in convert-jekyll subcommand?

@epage
Copy link
Member

epage commented Jan 29, 2018

The challenge will be that this is a non-default excerpt_separator so we can't build-in knowledge about it in a jekyll converter.

One option is we read the site config and apply the value in there to all files. I'm a bit mixed about doing something like that. On one hand, you generally don't change the excerpt separator globally after you've written posts, so it should be safe. On the other hand, it adds a lot of noise to frontmatters besides yours.

The other challenge is that this issue doesn't sound like its about problems with conversion but the site author changing their mind.

So another option is for us to define some kind of subcommand or flag for people to migrate excerpt_separators. It'd take the current value and push it out to all frontmatters so that its safe to change it for new pages. The problem with this is that having random subcommands or flags can clutter things up.

grumble Jekyll doesn't document the frontmatter variable excerpt_separator

@Geobert
Copy link
Contributor Author

Geobert commented Jan 29, 2018

Converting the excerpt_separator is a great idea, but without Jekyll standard it's hard to do…

@epage
Copy link
Member

epage commented Jan 29, 2018

but without Jekyll standard it's hard to do…

Can you clarify what you mean here?

@Geobert
Copy link
Contributor Author

Geobert commented Jan 29, 2018

The missing doc you grumbled about ^^

@epage
Copy link
Member

epage commented Jan 29, 2018

Its not documented but it seems we can count on it

@epage
Copy link
Member

epage commented Aug 31, 2018

Closed for cobalt-org/cobalt-migrate-jekyll#2

@epage epage closed this as completed Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants