Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nil literals #223

Closed
epage opened this issue Nov 6, 2018 · 0 comments
Closed

Support nil literals #223

epage opened this issue Nov 6, 2018 · 0 comments
Labels
enhancement Improve the expected format-break good first issue Help wanted! std-compatibility Jekyll flavor of liquid

Comments

@epage
Copy link
Member

epage commented Nov 6, 2018 •
edited

Looks like nil and null are supported as literals
https://github.com/Shopify/liquid/blob/master/lib/liquid/expression.rb

This involves

  • Creating keywords in the grammar for this
  • Create a nil literal parse function
  • Tying this into the generic literal parsing

Relevant tests

  • Once this is working, ideally the test will start failing. We would just need to remove the #[should_panic] on it
  • If the test doesn't start failing, please temporarily remove #[should_panic], and find or create an issue for the new failure
@epage epage added enhancement Improve the expected std-compatibility Jekyll flavor of liquid format-break labels Nov 6, 2018
This was referenced Nov 6, 2018
Merged
Closed
@epage epage added the good first issue Help wanted! label Dec 13, 2018
@epage epage closed this as completed in 7d3b0e5 Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected format-break good first issue Help wanted! std-compatibility Jekyll flavor of liquid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage