Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_reporting fails if empty string in ignorelist #1248

Closed
nhavens opened this issue Sep 16, 2014 · 1 comment
Closed

build_reporting fails if empty string in ignorelist #1248

nhavens opened this issue Sep 16, 2014 · 1 comment
Labels
Bug Report Reporting a bug Priority Issues that will be worked on with higher priority.

Comments

@nhavens
Copy link

nhavens commented Sep 16, 2014

The default configuration in the ubuntu 12.04 cobbler 2.6.5 package has the following in /etc/settings:

build_reporting_ignorelist = [""]

The code that reads this value is in install_post_report.py, and the condition that determines whether to send a build report email is:

for prefix in settings.build_reporting_ignorelist:
  if name.lower().startswith(prefix) == True:
    sendmail = False

With the default configuration, this check always succeeds, and mail is not sent.

Fix the issue by modifying the condition to:

  if prefix != '' and name.lower().startswith(prefix):
@jmaas jmaas added Bug Report Reporting a bug Priority Issues that will be worked on with higher priority. labels Sep 20, 2014
@jmaas
Copy link
Member

jmaas commented Sep 29, 2014

Fixed in master and release26. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Reporting a bug Priority Issues that will be worked on with higher priority.
Projects
None yet
Development

No branches or pull requests

2 participants