Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.6 Fails to start without proxy_url_ext (and _int?) defined in settings #1311

Closed
opoplawski opened this issue Oct 20, 2014 · 12 comments
Closed
Assignees
Labels

Comments

@opoplawski
Copy link
Contributor

Updated to 2.6.6 via yum. New settings file goes to settings.rpmnew. Without updating settings, cobblerd fails to start with:

Starting cobbler daemon: Traceback (most recent call last):
  File "/usr/bin/cobblerd", line 77, in main
    api = cobbler_api.BootAPI(is_cobblerd=True)
  File "/usr/lib/python2.6/site-packages/cobbler/api.py", line 135, in __init__
    self.deserialize()
  File "/usr/lib/python2.6/site-packages/cobbler/api.py", line 969, in deserialize
    return self._config.deserialize()
  File "/usr/lib/python2.6/site-packages/cobbler/config.py", line 266, in deserialize
    raise CX("serializer: error loading collection %s. Check /etc/cobbler/modules.conf" % item.collection_type())
CX: 'serializer: error loading collection repo. Check /etc/cobbler/modules.conf'

Editing config.py to keep the original exception shows:

  File "/usr/lib/python2.6/site-packages/cobbler/settings.py", line 271, in __getattr__
    raise AttributeError, name
AttributeError: proxy_url_ext

Adding the entries to settings fixes. Is there a way for the module to have a default value so we don't get an exception on load?

@alanoe
Copy link

alanoe commented Oct 20, 2014

the real discussion here is what to do when attributes are added/removed/updated in Cobbler settings. imho we should provide a migration script (easier for user) or provide required environment changes in release notes (easier for developers).

@jmaas
Copy link
Member

jmaas commented Oct 20, 2014

yes, my bad. it's hardwired into my brain to review .rpmnew files after upgrading....

but i agree we should handle this case more gracefuly...

@igalic
Copy link
Contributor

igalic commented Oct 21, 2014

between minor version upgrades, cobbler shouldn't fail to start, because a new attribute that's been added doesn't exist in the configuration file.

@alanoe alanoe self-assigned this Oct 23, 2014
@alanoe
Copy link

alanoe commented Oct 23, 2014

I'll add new proxy settings to DEFAULTS list in cobbler/settings.py, this will solve this problem.

@opoplawski
Copy link
Contributor Author

@jmaas - I'm waiting for a 2.6.7 with this fixed before pushing to EPEL. @alanoe - any progress?

@alanoe
Copy link

alanoe commented Oct 29, 2014

@opoplawski: a3a67a4 in master fixes this issue. It must be backported to 2.6 branch. I added all settings which were missing, must check if all of those exist in 2.6 branch. Obviously, the relevant ones are:

  • "proxy_url_ext": ["", "str"],
  • "proxy_url_int": ["", "str"],

@alanoe
Copy link

alanoe commented Nov 17, 2014

This was already merged to 2.6 branch. Should close this issue as soon as 2.6.7 is out.

@jmaas
Copy link
Member

jmaas commented Feb 7, 2015

2.6.7 has been released which fixes this issue.

@jmaas jmaas closed this as completed Feb 7, 2015
@robinbowes
Copy link

Did this get pushed? I don't see 2.6.7 in Fedora 21?

@jmaas
Copy link
Member

jmaas commented Apr 20, 2015

@opoplawski ?

@opoplawski
Copy link
Contributor Author

It's in updates-testing waiting for positive feedback: https://admin.fedoraproject.org/updates/FEDORA-2015-0039/cobbler-2.6.7-1.fc21

@robinbowes
Copy link

Ah, OK. I've grabbed it from there, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants