-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Red Hat subscription-manager #3540
base: main
Are you sure you want to change the base?
Conversation
@opoplawski Any update on this PR? |
At the moment I was looking for feedback to see if the approach made sense. If so I can clean it up next week. |
For obvious reasons, I don't have much insight into the RedHat Subscription management. I find your solution that is described in the description appropriate. I know that SUSE uses in Uyuni/SUSE Manager the |
35e4b6b
to
0ad0b5b
Compare
I'm not sure what kinds of tests if any should be added for this. Any direction would be appreciated. |
I pinged the SUMA people and hopefully they find the time to give you feedback on this PR. |
911ee13
to
246eeb6
Compare
246eeb6
to
051e62a
Compare
I've discovered that I've inserted some localisms in the use of |
`redhat_management_key` or `redhat_management_user`/`redhat_management_password`
051e62a
to
aa99b87
Compare
@agraul @meaksh @m-czernek @vzhestkov @ycedres please comment on this PR and its feature. This is directly related to the functionality you are maintaining in SUMA. |
In principle it seems that it just adds an alternative to register a Red Hat system using user/password or org/management_key but you can still register it using just the management key. So it does not change the already existing behaviour, is that right? |
That is certainly the intent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Linked Items
Fixes #3539
Description
This would add 3 more configuration parameters:
redhat_management_org
- Red Hat Organization IDredhat_management_user
- Red Hat user nameredhat_management_password
Red Hat passwordand would extend
redhat_management_key
to be a subscription-manager activation key when combined withredhat_management_org
.Behaviour changes
Old: No way to register systems with subscription-manager
New: Can register systems either with a user/password or with activation key and org ID
Category
This is related to a:
Tests
I'm not sure on the status of tests yet. I first wanted to get this out there for a quick review about the over all direction. I take it the existing rhnreg_ks is still in use by some people?