Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Red Hat subscription-manager #3540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opoplawski
Copy link
Contributor

Linked Items

Fixes #3539

Description

This would add 3 more configuration parameters:

  • redhat_management_org - Red Hat Organization ID
  • redhat_management_user - Red Hat user name
  • redhat_management_password Red Hat password
    and would extend redhat_management_key to be a subscription-manager activation key when combined with redhat_management_org.

Behaviour changes

Old: No way to register systems with subscription-manager
New: Can register systems either with a user/password or with activation key and org ID

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

I'm not sure on the status of tests yet. I first wanted to get this out there for a quick review about the over all direction. I take it the existing rhnreg_ks is still in use by some people?

@opoplawski opoplawski marked this pull request as draft January 2, 2024 22:33
@opoplawski opoplawski self-assigned this Jan 2, 2024
@SchoolGuy SchoolGuy mentioned this pull request Mar 8, 2024
12 tasks
@SchoolGuy
Copy link
Member

@opoplawski Any update on this PR?

@opoplawski
Copy link
Contributor Author

At the moment I was looking for feedback to see if the approach made sense. If so I can clean it up next week.

@SchoolGuy
Copy link
Member

For obvious reasons, I don't have much insight into the RedHat Subscription management. I find your solution that is described in the description appropriate. I know that SUSE uses in Uyuni/SUSE Manager the redhat_management_key and would like to keep the existing behavior. Defining additional non conflicting behaviour should be fully fine though.

@opoplawski
Copy link
Contributor Author

I'm not sure what kinds of tests if any should be added for this. Any direction would be appreciated.

@SchoolGuy
Copy link
Member

I pinged the SUMA people and hopefully they find the time to give you feedback on this PR.

@github-actions github-actions bot added documentation Improvements or additions to documentation tests labels Apr 23, 2024
@opoplawski opoplawski marked this pull request as ready for review April 23, 2024 21:03
@opoplawski opoplawski changed the title WIP: Initial work towards re-enabling subscription-manager Support Red Hat subscription-manager Apr 23, 2024
@opoplawski
Copy link
Contributor Author

I've discovered that I've inserted some localisms in the use of proxy_url_ext and --insecure to deal with our internal SSL filtering proxy. It may still be good to support that, but it should be conditional at least on proxy_url_ext being set.

`redhat_management_key` or `redhat_management_user`/`redhat_management_password`
@SchoolGuy
Copy link
Member

SchoolGuy commented May 9, 2024

@agraul @meaksh @m-czernek @vzhestkov @ycedres please comment on this PR and its feature. This is directly related to the functionality you are maintaining in SUMA.

@ycedres
Copy link
Contributor

ycedres commented May 10, 2024

In principle it seems that it just adds an alternative to register a Red Hat system using user/password or org/management_key but you can still register it using just the management key. So it does not change the already existing behaviour, is that right?

@opoplawski
Copy link
Contributor Author

That is certainly the intent.

Copy link
Contributor

@ycedres ycedres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Restore and expand support for registering systems with subscription-manager
3 participants