Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README.md #5

Merged
merged 1 commit into from Oct 2, 2020
Merged

Improve README.md #5

merged 1 commit into from Oct 2, 2020

Conversation

DmytroLitvinov
Copy link
Collaborator

Hi @cobusc ,

This PR fixs how we are adding into URLconf. Instead of django.conf.urls.url() lets show example with django.urls.path() - the new modern way. Also, url() will be deprecated in Django 4.0.

Also, let's show adding AppConfig as dotted path as it is recommended at Django docs. Otherwise we should add default_app_config variable inside __init__.py file.

@cobusc
Copy link
Owner

cobusc commented Oct 2, 2020

@DmytroLitvinov thanks for this. Do you mind updating the example/demo/{settings,urls}.py files to reflect these changes as well, please?

@DmytroLitvinov
Copy link
Collaborator Author

Okay. I will ping about finished changes.

@DmytroLitvinov DmytroLitvinov self-assigned this Oct 2, 2020
@DmytroLitvinov
Copy link
Collaborator Author

@cobusc , could you please check and provide your feedback?

@cobusc
Copy link
Owner

cobusc commented Oct 2, 2020

@DmytroLitvinov Looks good. Can you bump the version to 1.1.0 in setup.py, please? Then I'll merge and do the release ASAP.

@DmytroLitvinov
Copy link
Collaborator Author

I don't think that we need 1.1.0 version. It is only improvements of docs. No fixes or features.

@cobusc
Copy link
Owner

cobusc commented Oct 2, 2020

@DmytroLitvinov OK, so then I am just going to merge and not make a new release. Are you OK with that?

@DmytroLitvinov
Copy link
Collaborator Author

Sure 👍

@cobusc cobusc merged commit fcdd79a into cobusc:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants