Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck stats submission sends tokens along with cards #45

Closed
Daenyth opened this issue Jan 28, 2014 · 2 comments
Closed

Deck stats submission sends tokens along with cards #45

Daenyth opened this issue Jan 28, 2014 · 2 comments

Comments

@Daenyth
Copy link
Member

Daenyth commented Jan 28, 2014

"Don't include tokens and emblems when sending one's deck to deckstats.net for analysis from the Deck Editor. The site tries to interpret the tokens as the nearest matching cardname."

@Daenyth Daenyth added the Defect label Jun 17, 2014
@Daenyth Daenyth added this to the Maintenance Release milestone Jun 23, 2014
@arxanas
Copy link
Contributor

arxanas commented Jun 30, 2014

The new card importer doesn't actually detect tokens. I fixed that, so now it does — but by default, we don't save tokens to the XML file. So in previous versions of Cockatrice, our cards.xml would never have had a token to put into the deck, and thus this issue wouldn't arise.

Should the fix just be to properly detect and not include tokens in our cards.xml, or to include tokens and then not send them?

@woogerboy21
Copy link
Contributor

Is there any way you can write up what steps need to be taken to the PR request referenced in this to test the functionality change / differences?

Daenyth added a commit that referenced this issue Jul 23, 2014
Fix #45: don't send tokens to deckstats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants