Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preflight missing Access-Control headers #31

Closed
adiba opened this issue Oct 15, 2022 · 0 comments
Closed

Preflight missing Access-Control headers #31

adiba opened this issue Oct 15, 2022 · 0 comments

Comments

@adiba
Copy link

adiba commented Oct 15, 2022

With the die(); statement on this line https://github.com/Cockpit-HQ/Cockpit/blob/develop/index.php#L134
the access-control headers, which would be set at the 'before' event (in the lines above), are not sent out because 1) they are only set on the $apps response object and 2) the event doesn't have a chance of being fired.

Removing this line at least sends out the headers correctly.

This is the underlying issue of agentejo/cockpit#1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant