Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable columns for listview #564

Open
jelly opened this issue Jun 18, 2024 · 5 comments
Open

Configurable columns for listview #564

jelly opened this issue Jun 18, 2024 · 5 comments
Labels
enhancement New feature or request needs-design

Comments

@jelly
Copy link
Member

jelly commented Jun 18, 2024

We would like to add two more columns to the listview:

  • permission - showing -rw-r--r--. Do we sort this column based on the octal value so 777 > 600?
  • user/group - likely a separate column for both? (Sorting of course uses localCompare

We likely don't want to add these columns by default but allow a user to select what they want to show for which we have no UI.

@jelly jelly added enhancement New feature or request needs-design labels Jun 18, 2024
@garrett
Copy link
Member

garrett commented Jun 18, 2024

So I think we probably want to remove the sidebar (I'm working on that; we can have a status bar with the critical information instead) and we'd have enough space for owner (special merge of user+group) and permission.

Here's Nautilus has for customized columns in details mode:

image

But, again: Nautilus is a desktop file manager and we're on a server, etc., etc.

Nautilus doesn't have these most of these items on by default.

On a multi-user system, I think we might want different defaults. Permissions and ownership are more important on a multi-user server system than on a (usually, mostly) single-user desktop system.

@garrett
Copy link
Member

garrett commented Jun 18, 2024

I think we need to split out the parts of details that we want to have by default first, before even considering customization.

That is, we should have a PR for permissions first, then consider what to do about ownership, then consider if we even want customization.

@garrett
Copy link
Member

garrett commented Jun 18, 2024

For showing permissions, I think the only thing that makes sense is to have the descriptive form with triplet attributes (not octal), and have descriptions for it in a tooltip to make it more approachable, like this:

permissions in details, with a tooltip

Note the spacing, lack of d (as we have another place to show if it's a directory or file`), and grouping. The tooltip has alignment on the labels and for the content, so the content aligns (and isn't ragged due to being all in one line).

@allisonkarlitskaya
Copy link
Member

Please make sure to support s (+xs), S (+s-x) and t (sticky) in the output for permissions.

@garrett
Copy link
Member

garrett commented Jun 20, 2024

I don't think we want to add configurability, at least not until we need to. Here are all the fields for details that I think we might want to include. It's not too much:

Board(3)

I don't think we should show octals. People generally don't understand that as well as the symbolic variants. If we split it into triplets like in the mockup, then it becomes even more obvious which is user, group, and others.

Note, not related to this PR, but related to the mockup: I collapsed user:group into owner, as most distributions use "User Private Groups" (UPG), where user:group is basically always user:user by default, so showing just "user" would be the main default, and you can easily then see when something is assigned to another group separate from the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-design
Projects
None yet
Development

No branches or pull requests

3 participants