Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo needs a review #13

Closed
maddyblue opened this issue Feb 10, 2017 · 3 comments
Closed

Quo needs a review #13

maddyblue opened this issue Feb 10, 2017 · 3 comments
Assignees
@eisenstatdavid

Comments

@maddyblue
Copy link
Contributor

spec at: http://speleotrove.com/decimal/daops.html#refdivide
@eisenstatdavid
Copy link
Contributor

Does this include QuoInteger?

@eisenstatdavid
Copy link
Contributor

Both LGTM, subject to two hopefully expected caveats:

  1. Special values are not handled properly. ISTM that the decimal type can't represent NaN, -∞, -0, or ∞.
  2. Quo implements long division, which is slow for large operands. Newton–Raphson division is one possible upgrade path.

@maddyblue
Copy link
Contributor Author

No, QuoInteger isn't required. It's a much simpler algorithm.

I wasn't aware of Newton-Raphson. I'll open an issue so we don't forget.

@maddyblue maddyblue mentioned this issue Feb 16, 2017
Closed
@maddyblue maddyblue mentioned this issue Sep 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eisenstatdavid eisenstatdavid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maddyblue @eisenstatdavid