Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent transaction from committing on panic. #76

Closed
umran opened this issue Jun 15, 2020 · 0 comments · Fixed by #119
Closed

Prevent transaction from committing on panic. #76

umran opened this issue Jun 15, 2020 · 0 comments · Fixed by #119
Labels
help wanted
Projects
SQL Sessions - Deprecated

Comments

@umran
Copy link

umran commented Jun 15, 2020

Currently there is no check for panics within the ExecTx closure. I think it could be useful to have a deferred function rollback the transaction if there is a panic.
@rafiss rafiss added this to To triage in SQL Sessions - Deprecated via automation Sep 10, 2020
@rafiss rafiss moved this from Triage to Longer term backlog in SQL Sessions - Deprecated Nov 24, 2020
@hahashraf hahashraf mentioned this issue Oct 29, 2021
Merged
SQL Sessions - Deprecated automation moved this from Longer term backlog to Done Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
No open projects
SQL Sessions - Deprecated
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rollback on panic
2 participants
@rafiss @umran