Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize use improvement #63

Closed
chrislovecnm opened this issue Jul 11, 2020 · 5 comments
Closed

kustomize use improvement #63

chrislovecnm opened this issue Jul 11, 2020 · 5 comments

Comments

@chrislovecnm
Copy link
Contributor

We are using kustomize for some of the acceptance testing scripts.

https://github.com/cockroachdb/cockroach-operator/blob/bbfc23a928c1c1d39f167057ac814756a1c5d00f/hack/apply-operator.sh#L50-51

This script is a bit messy since it modifies one of the files, and git then wants to check it in. We need to copy the file to a temp folder and then use kustomize to deploy those files.

@johnrk-zz johnrk-zz added this to To do in Kubernetes Operator via automation Jul 13, 2020
@johnrk-zz johnrk-zz added this to To do in Cockroach Kubernetes Operator via automation Jul 14, 2020
@johnrk-zz johnrk-zz removed this from To do in Kubernetes Operator Jul 14, 2020
@johnrk-zz johnrk-zz moved this from Triage to To do in Cockroach Kubernetes Operator Jul 15, 2020
@johnrk-zz johnrk-zz moved this from To do to Triage in Cockroach Kubernetes Operator Jul 15, 2020
@chrislovecnm
Copy link
Contributor Author

We can get rid of kustomize I think because of bazel. I will leave this open for now.

@johnrk-zz johnrk-zz added this to Triage in Cockroach Kubernetes Operator via automation Jan 28, 2021
@johnrk-zz johnrk-zz moved this from Triage to Backlog in Cockroach Kubernetes Operator Jan 28, 2021
@johnrk-zz
Copy link
Contributor

@chrislovecnm , can you confirm that we can close this?

@cten
Copy link

cten commented May 11, 2021

Just curious, this is for stopping the use of kustomize in testing but not to remove the kustomization files from the repo correct?

@johnrk-zz
Copy link
Contributor

^ @chrislovecnm

@udnay
Copy link
Collaborator

udnay commented Jun 26, 2021

Bump this again, can we close this?

Cockroach Kubernetes Operator automation moved this from Backlog to Done Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants