Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix the batching behavior of mutation statements, especially with RETURNING #3068

Closed
jseldess opened this issue May 3, 2018 · 2 comments
Assignees
Milestone

Comments

@jseldess
Copy link
Contributor

jseldess commented May 3, 2018

PR: cockroachdb/cockroach#23373

From release notes:

The EXPLAIN output for UPDATE statements now also report CHECK expressions, for consistency with INSERT. [#23373][#23373] {% comment %}doc{% endcomment %}

@jseldess jseldess added this to the 2.1 milestone May 3, 2018
@rmloveland rmloveland self-assigned this May 8, 2018
@rmloveland
Copy link
Contributor

@knz It's my opinion that this issue does not require a doc update. Do you agree with that assessment?

For context, I played with the EXPLAIN DELETE FROM ... and EXPLAIN INSERT INTO ... output from the tests a bit, but AFAICT we don't currently document the EXPLAIN output at the "statement X is EXPLAINed as output Y" level of granularity. Please let me know if I'm misunderstanding something here, though.

@jseldess jseldess added the A-sql label Oct 4, 2018
@knz
Copy link
Contributor

knz commented Oct 5, 2018

It's my opinion that this issue does not require a doc update. Do you agree with that assessment?

correct!

@knz knz closed this as completed Oct 5, 2018
@jseldess jseldess added fixitday and removed ready labels Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants