Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rolling Upgrades for the cockroachdb installed through helm chart #303

Open
prafull01 opened this issue Mar 27, 2023 · 2 comments
Open

Comments

@prafull01
Copy link
Collaborator

Rolling Upgrade for cockroach db statefulset:

Every pod of statefulset should be upgraded one by one and it should wait for the cockroach db cluster to be ready state before upgrading to the new cluster.
Currently, helm chart will upgrade the statefulset in rolling upgrade but it doesn't wait for cockroach cluster to be ready before it upgrades to the next replica.

Proposed Solution:

We already have self-signer utility for certificate management, we can expand that utility to do rolling start as well. This utility will have a sub command of rolling-restart and this will upgrade the statefulset into rolling restart fashion and wait for cockroach db cluster to be ready before upgrading the next pod. We are already doing this for the cockroach operator

This utility will be invoked as pre-upgrade command and can be enabled or disable through the values.yaml.

@prafull01
Copy link
Collaborator Author

@udnay Please share your thoughts on this

@udnay
Copy link
Collaborator

udnay commented Apr 4, 2023

This approach seems fine to me, @chrisseto @pseudomuto anything totally off with this before @prafull01 writes up a more detailed RFC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants