Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prevent 'liked' or marked images from being deleted. #50

Open
Cornmeister opened this issue Mar 1, 2023 · 2 comments

Comments

@Cornmeister
Copy link

First of all, great tool!

I downloaded it for cleaning my StableDiffusion output folder.
I'm going to trash almost every image, but there are some I would like to keep.

I would like to see an option to mark an image as 'do not delete'. Probably you can use the Like icon for it.
When I have selected the best images, I should be able to select all, and press the delete button, without deleting the marked images.

@Cornmeister Cornmeister changed the title [Feature Request] Prevent 'liked' images from being deleted. [Feature Request] Prevent 'liked' or marked images from being deleted. Mar 1, 2023
@MalikKillian
Copy link

I definitely think this is a "must have" feature. It stands to reason if I mark something "liked" that I wouldn't want to delete it.

To keep it from maybe being too imposing it would be fine with me if there was a checkbox (unchecked by default) in the deletion dialog so only non-liked images are deleted unless the box is checked.

Seems pretty simple to do using something like this: https://www.christianengvall.se/electron-show-messagebox/

Maybe if I have the time (and don't forget about it) I'll submit a pull request.

@MalikKillian
Copy link

MalikKillian commented Jul 13, 2023

I made a PR. Hopefully it's accepted soon. I know the maintainer has been busier with other stuff.

I wanted to make a fancy dialog with a checkbox but that gets tricky because most logic is in breadmachine. Didn't want to switch to a HTML-based popup just for this. https://github.com/t4t5/sweetalert looks cool but I hate to add more dependencies to what is a fairly lean project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants