Improve accessibility by announcing changed values #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry for the delay, I think it looks good. Do you mind bumping a new version for the pod spec as well? |
|
Sure, just pushed up a version bump |
Source/AIFlatSwitch.swift
Outdated
| @@ -176,6 +176,7 @@ import UIKit | |||
| // Animate to new state | |||
| if animated { | |||
| self.addAnimations(desiredSelectedState: isSelectedInternal) | |||
| self.accessibilityValue = isSelected ? "checked" : "unchecked" | |||
There was a problem hiding this comment.
@marcuswu I also noticed indentation looks weird here, is it same for you?
There was a problem hiding this comment.
Fixed -- I had spaces vs the rest of the file which uses tabs. It appeared the same in my editor.
|
Does it look good? I'm happy to make further changes if necessary. |
|
Hey @marcuswu sorry again for the delay 😔 and thanks for your contribution |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change announces the changed value. I do it in the animation check because it's not necessary to announce the value change during initialization. If you want to suggest a better way to do this, I'm open to ideas.