change template config file to camel case syntax #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggo
reviewed
Sep 18, 2020
| "project_replace_package_name": { | ||
| "src_package_name": "org.cocos2dx.hellojavascript", | ||
| "projectReplacePackageName": { | ||
| "srcPackageName": "org.cocos2dx.hellojavascript", |
There was a problem hiding this comment.
cocos2dx -> cocos 会好一些，尽量不实用 cocos2d-x .
There was a problem hiding this comment.
hellojavascript 可以改成 helloworld 了。之前是因为有多种语言，所以用 hellojavascript
PatriceJiang
approved these changes
Sep 18, 2020
|
这个等到下面这个 PR 合并后，再合并，不然可能导致编辑器和-lite不匹配导致无法构建原生工程。 |
| @@ -26,20 +26,20 @@ | |||
| "to": "${COMMON_DIR}/cocos2d-x" | |||
| }, | |||
| "projectReplacePackageName": { | |||
| "srcPackageName": "org.cocos2dx.hellojavascript", | |||
| "srcPackageName": "com.cocos.helloworld", | |||
There was a problem hiding this comment.
比如 templates\template-link\platforms\android\app\build.gradle 中的文本也要替换
minggo
reviewed
Sep 24, 2020
| "from": "cocos/bindings/manual/jsb_module_register.cpp", | ||
| "doAddNativeSupport": { | ||
| "appendFile": [{ | ||
| "from": "cocos/scripting/js-bindings/manual/jsb_module_register.cpp", |
minggo
reviewed
Sep 24, 2020
| "files": [ | ||
| "${COMMON_DIR}/CMakeLists.txt" | ||
| ] | ||
| }, | ||
| "project_replace_cocos_x_root": { | ||
| "projectReplaceCocosXRoot": { |
There was a problem hiding this comment.
projectReplaceCocosXRoot -》 projectReplaceCocosRoot
minggo
reviewed
Sep 24, 2020
| "files": [ | ||
| "${COMMON_DIR}/CMakeLists.txt" | ||
| ] | ||
| }, | ||
| "project_replace_cocos_x_root": { | ||
| "projectReplaceCocosXRoot": { | ||
| "pattern":"\\$\\{COCOS_X_ROOT\\}", | ||
| "files": [ | ||
| {"file": "${COMMON_DIR}/CMakeLists.txt", "default":"${CMAKE_CURRENT_LIST_DIR}/cocos2d-x", "needFix":true}, | ||
| {"file": "proj/settings.gradle", "default":"${COMMON_DIR}/cocos2d-x", "needFix":true}, | ||
| {"file": "proj/app/build.gradle", "default":"${COMMON_DIR}/cocos2d-x", "needFix":true}, |
Signed-off-by: wuzhiming <wuzhiming.chukong@gmail.com>
Signed-off-by: wuzhiming <wuzhiming.chukong@gmail.com>
Signed-off-by: wuzhiming <wuzhiming.chukong@gmail.com>
Signed-off-by: wuzhiming <wuzhiming.chukong@gmail.com>
wuzhiming
force-pushed
the
3d-gfx_change_template_config
branch
from
d474b10
to
867276f
Compare
Signed-off-by: wuzhiming <wuzhiming.chukong@gmail.com>
PatriceJiang
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用驼峰，来跟编辑器保持一致，后续已经把新版本cocos console 合并入编辑器，后续编辑器版本稳定后，再删除现有的console代码