add hasEventListener for CCEventDispatcher #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
approved these changes
Dec 6, 2016
minggo
reviewed
Dec 7, 2016
| * | ||
| * @return True if dispatching events is exist | ||
| */ | ||
| bool hasEventListener(std::string listenerID); |
There was a problem hiding this comment.
bool hasEventListener(std::string listenerID) -> bool hasEventListener(const std::string& listenerID) const
| @@ -857,6 +857,11 @@ void EventDispatcher::dispatchCustomEvent(const std::string &eventName, void *op | |||
| dispatchEvent(&ev); | |||
| } | |||
|
|
|||
| bool EventDispatcher::hasEventListener(std::string listenerID) | |||
| { | |||
| return getListeners(listenerID) != nullptr; | |||
There was a problem hiding this comment.
getListeners接收的参数类型不是std::string啊
|
已经修复 @minggo |
minggo
reviewed
Dec 7, 2016
| * | ||
| * @return True if dispatching events is exist | ||
| */ | ||
| bool hasEventListener(const EventListener::ListenerID& listenerID); |
There was a problem hiding this comment.
bool hasEventListener(const EventListener::ListenerID& listenerID) -> bool hasEventListener(const EventListener::ListenerID& listenerID) const
minggo
approved these changes
Dec 8, 2016
bofeng-song
pushed a commit
to bofeng-song/cocos2d-x-lite
that referenced
this pull request
Dec 29, 2021
refine for_each_tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cocos-creator/fireball/issues/4862
添加 hasEventListener 函数
@minggo @pandamicro @dumganhar 看看如果没问题谁合并一下 thx