3.4.1 Android: Java flush game thread tasks #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatriceJiang
commented
Jan 18, 2022
Comment on lines
+142
to
+147
| List<Runnable> tmp = sTaskOnGameThread; | ||
| synchronized (sTaskMtx) { | ||
| sTaskOnGameThread = Collections.synchronizedList(new ArrayList<>()); | ||
| } | ||
| while (tmp.size() > 0) { | ||
| Runnable r = tmp.remove(0); |
There was a problem hiding this comment.
避免循环中修改队列, 修复潜在无法退出的问题
runOnGameThread(()-> {
...
runOnGameThread(()->{..});
...
});
PatriceJiang
commented
Jan 18, 2022
Comment on lines
+130
to
+136
| List<Runnable> tmp = sTaskOnGameThread; | ||
| synchronized (sTaskMtx) { | ||
| sTaskOnGameThread = Collections.synchronizedList(new ArrayList<>()); | ||
| } | ||
| while (tmp.size() > 0) { | ||
| Runnable r = tmp.remove(0); | ||
| if (r != null) { |
PatriceJiang
changed the title
PatriceJiang
changed the title
minggo
approved these changes
Jan 19, 2022
PatriceJiang
commented
Jan 19, 2022
Comment on lines
+166
to
+171
| if(game) { | ||
| // Handle java events send by UI thread. Input events are handled here too. | ||
| cc::JniHelper::callStaticVoidMethod("com.cocos.lib.CocosHelper", | ||
| "flushTasksOnGameThread"); | ||
| } | ||
| if (game && cc::cocosApp.animating) { |
There was a problem hiding this comment.
后台继续执行 runOnGameThread 任务, 不再执行 gameTick. 和 2.x 保持一致
PatriceJiang
commented
Jan 19, 2022
| runInLowRate = !cc::cocosApp.animating || APP_CMD_PAUSE == cc::cocosApp.appState; | ||
|
|
||
| if (readCommandWithTimeout(cmd, runInLowRate ? 100 : 0) > 0) { | ||
| if (readCommandWithTimeout(cmd, runInLowRate ? 50 : 0) > 0) { |
PatriceJiang
commented
Jan 19, 2022
| runInLowRate = !cc::cocosApp.animating || APP_CMD_PAUSE == cc::cocosApp.appState; | ||
|
|
||
| if (readCommandWithTimeout(cmd, runInLowRate ? 100 : 0) > 0) { | ||
| if (readCommandWithTimeout(cmd, runInLowRate ? 50 : 0) > 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cocos-creator/3d-tasks/issues/10902