fix CCMotionStreak err for fireball/issues/5881 #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jareguo
reviewed
Jun 12, 2017
| }, | ||
|
|
||
| onDisable: function () { | ||
| this.node.off('position-changed', this._onNodePositionChanged, this); |
There was a problem hiding this comment.
这个事件只能监听到 node 本身的位移，监听不到父节点的位移，恐怕会有 bug 吧？
| @@ -279,7 +288,6 @@ var MotionStreak = cc.Class({ | |||
| var ty = worldMt.ty - (node.height / 2 + node.anchorY * node.height); | |||
| this._root.setPosition(-tx, -ty); | |||
| this._motionStreak.setPosition(tx, ty); | |||
| this._motionStreak.update(delta); | |||
There was a problem hiding this comment.
这里把 update 函数调用去掉了不会有问题么。。。
There was a problem hiding this comment.
没问题，因为 update 会被执行
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/fireball#5881
Changes proposed in this pull request:
@cocos-creator/engine-admins