fix audioEngine deprecated code for fireball/issues/6058 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jareguo
reviewed
Jul 18, 2017
cocos2d/audio/deprecated.js
Outdated
| @@ -104,7 +104,7 @@ exports.deprecated = function (audioEngine) { | |||
| // cc.warn(INFO, 'audioEngine.playEffect', 'audioEngine.play'); | |||
|
|
|||
| return function (url, loop, volume) { | |||
| return audioEngine.play(url, loop, volume === undefined ? effectsVolume : volume); | |||
| return audioEngine.play(url, loop || false, volume || effectsVolume); | |||
|
我看了下，CCAudioEngine.js 中，本来就有对参数进行校验和转换了。你这里的应该是 jsb polyfill 里面要实现的逻辑，而不是 deprecated 要实现的。 |
|
jsb-audio 里面会去调用 deprecated 里面的函数，所以还是在 deprecated 做才行 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/fireball#6058
Changes proposed in this pull request:
@cocos-creator/engine-admins