Fixed that we forget to observe onTouchCancelled event. #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
suggested changes
Feb 24, 2018
| @@ -204,6 +204,23 @@ var _touchEndHandler = function (touch, event) { | |||
| Event.EventTouch.pool.put(event); | |||
| } | |||
| }; | |||
| var _touchCancelHandler = function (touch, event) { | |||
There was a problem hiding this comment.
把前面 end handler 里面的 hitTest 给去掉把，也不需要 touch cancel 的处理了
There was a problem hiding this comment.
end handler 需要 hittest吧，为什么要去掉？
cancel 才不需要吧？
pandamicro
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复引擎没有处理系统派发的 touch cancel 事件的问题。
Reported at http://forum.cocos.com/t/touch-bug/56674