Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MeshRenderData.resize for changing both buffer size and ia size #9986

Merged
merged 4 commits into from Jan 13, 2022

Conversation

pandamicro
Copy link
Contributor

No description provided.

@pandamicro pandamicro changed the title V3.4.1 Add MeshRenderData.resize for changing both buffer size and ia size Jan 13, 2022
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -3230,17 +3230,17 @@
         lastFilledVertex: number;
         constructor(vertexFormat?: gfx.Attribute[]);
         request(vertexCount: number, indexCount: number): boolean;
         reserve(vertexCount: number, indexCount: number): boolean;
+        resize(vertexCount: number, indexCount: number): void;
         updateRange(vertOffset: number, vertexCount: number, indexOffset: number, indexCount: number): void;
         requestIA(device: gfx.Device): gfx.InputAssembler;
         uploadBuffers(): void;
         freeIAPool(): void;
         reset(): void;
         clear(): void;
         protected _initIAInfo(device: gfx.Device): void;
         protected _reallocBuffer(vCount: any, iCount: any): void;
-        resize(vertexCount: number, indexCount: number): void;
     }
     export class QuadRenderData extends MeshRenderData {
         protected _reallocBuffer(vCount: any, iCount: any): void;
     }
@@ -16994,8 +16994,13 @@
          */
         isPersistRootNode(node: {
             _persistNode: any;
         }): boolean;
+        /**
+         * TODO: Only hack for PhysX initialization, should be removed in future
+         * @internal
+         */
+        onEngineInitedAsync(func: () => (Promise<void> | void)): void;
     }
     export namespace Game {
         export type OnStart = () => void;
     }

@@ -423,9 +424,9 @@ function traverseGrids (leftDown: { col: number, row: number }, rightTop: { col:
// begin to fill vertex buffer
tiledNode = tiledTiles[colData.index];

_renderData!.renderData.reserve(4, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前和现在数字对不上?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复

@pandamicro
Copy link
Contributor Author

@cocos-robot run test cases

@pandamicro pandamicro merged commit 39fb445 into cocos:v3.4.1 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants