New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MeshRenderData.resize for changing both buffer size and ia size #9986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandamicro
changed the title
V3.4.1
Add MeshRenderData.resize for changing both buffer size and ia size
Jan 13, 2022
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -3230,17 +3230,17 @@
lastFilledVertex: number;
constructor(vertexFormat?: gfx.Attribute[]);
request(vertexCount: number, indexCount: number): boolean;
reserve(vertexCount: number, indexCount: number): boolean;
+ resize(vertexCount: number, indexCount: number): void;
updateRange(vertOffset: number, vertexCount: number, indexOffset: number, indexCount: number): void;
requestIA(device: gfx.Device): gfx.InputAssembler;
uploadBuffers(): void;
freeIAPool(): void;
reset(): void;
clear(): void;
protected _initIAInfo(device: gfx.Device): void;
protected _reallocBuffer(vCount: any, iCount: any): void;
- resize(vertexCount: number, indexCount: number): void;
}
export class QuadRenderData extends MeshRenderData {
protected _reallocBuffer(vCount: any, iCount: any): void;
}
@@ -16994,8 +16994,13 @@
*/
isPersistRootNode(node: {
_persistNode: any;
}): boolean;
+ /**
+ * TODO: Only hack for PhysX initialization, should be removed in future
+ * @internal
+ */
+ onEngineInitedAsync(func: () => (Promise<void> | void)): void;
}
export namespace Game {
export type OnStart = () => void;
}
|
holycanvas
reviewed
Jan 13, 2022
@@ -423,9 +424,9 @@ function traverseGrids (leftDown: { col: number, row: number }, rightTop: { col: | |||
// begin to fill vertex buffer | |||
tiledNode = tiledTiles[colData.index]; | |||
|
|||
_renderData!.renderData.reserve(4, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前和现在数字对不上?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修复
@cocos-robot run test cases |
holycanvas
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.