Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A libflatbuffers is build inside 3rd party bins? #172

Open
martell opened this issue Jul 22, 2015 · 4 comments
Open

A libflatbuffers is build inside 3rd party bins? #172

martell opened this issue Jul 22, 2015 · 4 comments

Comments

@martell
Copy link

martell commented Jul 22, 2015

Can we move this to 3rd party source instead I have submitted a PR to google/flatbuffers with a patch to do just this you guys are welcome to use that patch in 3rd party source repo

google/flatbuffers#238

@ricardoquesada Hi.

I'm trying to rebuild 3.7 for the new msys2 release and having source in 3rd party bins is causing issues again :D

@martell
Copy link
Author

martell commented Jul 26, 2015

The google maintainer of the google/flatbuffers project has merged my PR.
So with the next release version cocos2d-x should no longer need have a custom binary blob where as there will be an official libflatbuffers

@zilongshanren
Copy link
Member

@martell Good job 👍

@ricardoquesada
Copy link
Contributor

+1 for moving flatbuffers to src.
@minggo @pandamicro do you know why it is in bin?

@pandamicro
Copy link
Contributor

I'm not sure why it's in bin, it's originally integrated by Beijing studio team, @chengstory @geron-cn @xiaofeng11 Maybe you guys know something ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants