-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning when building for iOS #35
Comments
I replaced jpeg/prebuilt/ios/libjpeg.a to a binary from libjpeg-turbo and this warning disappeared. This binary however doesn't include a slice for arm64. After fixing the warning for libjpeg, the same warning appeared for libtiff:
Replacing tiff/prebuilt/ios/libtiff.a also fixed the warning. There were no more warnings concerning PIE and now running "otool -hv" on the .app shows the PIE flag (it didn't before). I don't know how libjpeg and libtiff are being compiled but it might be worth looking into it. Thanks. |
where did you get the libtiff.a library to replace the one in "tiff/prebuilt/ios/" ? thanks! |
I don't remember, sorry - I vaguely remember trying to compile it but not sure if I was successful or if I ended up grabbing a binary online. |
For those interested, grab the libs package from Imagemagick: And replace for cocos2d-x/external/jpeg and cocos2d-x/external/tiff both the include files and the prebuilt libs for ios with the ones from Imagemagick. Clean and rebuild and all should be fine. "otool -hv" shows PIE flag. Don't forget, if you run "download-deps.py", those files are overwritten again ... |
Those are great, thanks! They include armv64 and starting on February 1st 2015, new apps will require 64-bit support: https://developer.apple.com/news/?id=10202014a
Edit: Actually I just tried them out in my project (which is using cocos2d-x 3.2) and I get the following error:
|
did you copy all the headers ? (i think there is one additional header for jpeg) |
I didn't, might have been that. Thanks. |
no worries all works in my projects |
I thought non-PIE apps are not allowed on the appstore? I wonder why nobody of the regular cocos2d-x maintainers have noticed this problem. I just moved to the latest 3.3rc0 and the problem still persists |
Apple prefers PIE apps, but you can still submit a non-PIE app and it will probably be accepted - they might give you a warning about that though. |
Noticed the warning a long time ago, didn't submit a non-pie app for a while. Thought they would have forced it by now... |
I'm on cocos2d-x 3.3 and still get this warning. I tried the suggest libraries above and this did not fix it. |
@Pstoppani |
I created a simple project in 3.3 and ran it on my iPhone. Pete
|
Still persists in cocos2d-x 3.4.
|
@minggo |
Yes please if it doesn't have any side-effect. |
Shouldn't cpp-test be setup for best practice? Not working around this issue by setting it to YES, but rather keeping it as NO and fixing the issue with the core and 3rd party libraries? |
@stevetranby |
@stevetranby I will consider to compile all the 3rd party libraries with PIE flag. But now it doesn't has such a high priority. |
Still seeing this in Cocos2dX 3.5. What do I do?? |
@jonnyijapan Fixed at #137 |
Hello, when building my cocos2d-x game project for iOS I get the following warning:
From the _jinit_arith_decoder and jdarith.o in the warning I'm deducing it originates from libjpeg (hence posting this issue in this repository). Also this error only occurs when building for a device and not the simulator, so maybe not all slices of libjpeg cause this.
I'm not really sure what is happening but it might be important - the app no longer builds as PIE which Apple doesn't like according to their documentation: https://developer.apple.com/library/ios/qa/qa1788/_index.html#/apple_ref/doc/uid/DTS40013354
The text was updated successfully, but these errors were encountered: