Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is it on purpose or mistake? #144

Closed
springrider opened this issue Mar 7, 2017 · 6 comments
Closed

is it on purpose or mistake? #144

springrider opened this issue Mar 7, 2017 · 6 comments

Comments

@springrider
Copy link

springrider commented Mar 7, 2017 •
edited

4961d9e recovered websocket header config with "websockets_header_files=l*.h
", and months later 66c86a8 reverted it...
@minggo
Copy link
Contributor

minggo commented Mar 7, 2017

it is on purpose, because l*.h will match unneeded header files

@minggo minggo closed this as completed Mar 7, 2017
@springrider
Copy link
Author

the current version of cocos2d-x lite has lws_config.h included. it is not necessary anymore?

@minggo
Copy link
Contributor

minggo commented Mar 7, 2017

it is needed, but can not just use l*.h to match it, may be should create a new issue

@springrider
Copy link
Author

I am not sure why, but after change it back to "l*.h", it only copied the necessary file "lws_config.h" and "libwebsockets.h".. which is the correct behaviour...

@minggo
Copy link
Contributor

minggo commented Mar 7, 2017

it is because you only build websocket

@springrider
Copy link
Author

right, new issue then, thanks.

@springrider springrider mentioned this issue Mar 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springrider @minggo