Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cython implementation #4

Closed
fkhan00 opened this issue Aug 24, 2019 · 2 comments
Closed

Cython implementation #4

fkhan00 opened this issue Aug 24, 2019 · 2 comments

Comments

@fkhan00
Copy link

fkhan00 commented Aug 24, 2019

I was thinking of using cython to run autofeat in C and changing some of the variables to static. Do you think this would make autofeat significantly faster?

@cod3licious
Copy link
Owner

Hey @fkhan00 : the main bottleneck is the feature generation using the sympy library (which computes the different feature formulas to make sure there are no redundant features being generated etc.). Since it's probably not possible to improve a lot there with cython, I'm not sure if you'll really get a huge performance boost. But if you try it and it helps, I'd be happy about a pull request! :) good luck!

@Sandy4321
Copy link

better without cython pls, since it is usually problem to install code based on cython
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants