Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with setting up coverage with CircleCI #127

Closed
lilithxxx opened this issue Jul 31, 2019 · 2 comments
Closed

Issue with setting up coverage with CircleCI #127

lilithxxx opened this issue Jul 31, 2019 · 2 comments

Comments

@lilithxxx
Copy link

lilithxxx commented Jul 31, 2019

We are trying to set up codacy with CircleCI and are running into issues because CircleCI does not advise turning on the setting "pass-secrets-to-builds-from-forked-pull-requests" (https://circleci.com/docs/2.0/oss/#pass-secrets-to-builds-from-forked-pull-requests). This setting is necessary to be enabled else the env variable 'CODACY_PROJECT_TOKEN' won't be accessible in the commits and PRs.

So, is it advisable to turn on the above setting and if not, is there any other way the env variable (CODACY_PROJECT_TOKEN) can be accessed?

@ljmf00
Copy link
Contributor

ljmf00 commented Sep 4, 2019

Hi @lilithxxx ,

Passing secrets to builds from forked PRs is dangerous, if you have actual secrets there. Because CODACY_PROJECT_TOKEN is supposed to be private, you should skip the coverage if you don't have that environment variable available.

@mrfyda
Copy link
Member

mrfyda commented Nov 8, 2019

I added this as product feedback to our backlog under "Authentication to upload coverage for forks PRs".

@mrfyda mrfyda closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants