Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gem version to 3.1.0 #69

Merged
merged 1 commit into from May 16, 2013
Merged

Bump gem version to 3.1.0 #69

merged 1 commit into from May 16, 2013

Conversation

tjschuck
Copy link
Collaborator

@tjschuck tjschuck commented May 7, 2013

Per http://semver.org, since the last version, "new, backwards compatible functionality [has been] introduced to the public API", so it should be incremented on the minor version.

Since there was no comment on #67, I'm not sure if you agree with the restructuring there. If you agree with that one (or just want to discuss it on that pull request), you can just address this one after that one. If you disagree with the restructuring, that's a-okay with me (just a matter of preference), but I'd still like the gem version bumped so I can start using this version without needing git refs.

Thanks!

@tjschuck
Copy link
Collaborator Author

The Travis build errored out on the main repo's Travis account, but just to confirm that it's still all green, it passed on my fork: https://travis-ci.org/tjschuck/bcrypt-ruby/builds/6974120

@tjschuck
Copy link
Collaborator Author

(Bump) -- any chance of this happening? /cc @tmm1?

@tmm1
Copy link
Collaborator

tmm1 commented May 15, 2013

@codahale Can you give @tjschuck commit?

@codahale
Copy link
Contributor

Done. BTW, it would be awesome if someone who still writes Ruby would take this repo off my hands.

Per http://semver.org, since the last version, "new, backwards compatible functionality is introduced to the public API", so it should be incremented on the minor version.
tjschuck added a commit that referenced this pull request May 16, 2013
@tjschuck tjschuck merged commit b897de2 into bcrypt-ruby:master May 16, 2013
@tjschuck
Copy link
Collaborator Author

@tmm1 All merged, but one of the RubyGems owners will have to publish and submit the new version: http://rubygems.org/gems/bcrypt-ruby (or you can add me to that as well).

@tmm1
Copy link
Collaborator

tmm1 commented May 16, 2013

% gem owner -a tj@tjschuck.com bcrypt-ruby
Pushing gem to https://rubygems.org...
Owner added successfully.
Pushing gem to https://rubygems.org...
Owners for gem: bcrypt-ruby
- tj@tjschuck.com
- coda.hale@gmail.com
- gemcutter@tmm1.net
- aaron.patterson@gmail.com

@tjschuck
Copy link
Collaborator Author

@tmm1 Thanks!

@bf4
Copy link
Contributor

bf4 commented Jul 3, 2013

@tjschuck 3.1.0 not up on https://rubygems.org/gems/bcrypt-ruby/versions 3.0.1 is still the latest up there. I'm happy to help too, if wanted. I'm https://rubygems.org/profiles/bf4

@tjschuck
Copy link
Collaborator Author

tjschuck commented Jul 3, 2013

@bf4 Sorry -- I'll try to get that up shortly. In the meantime, you can always just use a git ref if you're installing via Bundler:

gem 'bcrypt-ruby', require: 'bcrypt', github: 'codahale/bcrypt-ruby', ref: 'c4a7a65e55b498c4e26d4d939082eeb4c2041ea6'

@bf4
Copy link
Contributor

bf4 commented Jul 4, 2013

I know. I've had it on my fork until I just checked to see a new version
was released with my code in it, so I was excited to specify a gem version
and speed up bundling... but the gem wasn't on rubygems.org :)

@tjschuck
Copy link
Collaborator Author

tjschuck commented Jul 5, 2013

@bf4 It's up there now. Sorry for the delay.

@tmm1
Copy link
Collaborator

tmm1 commented Jul 5, 2013

@tjschuck Thanks. Did you have any issues building the win32 and java binary gems?

@tjschuck
Copy link
Collaborator Author

tjschuck commented Jul 5, 2013

@tmm1 Tons of issues :)

I ended up building this to help me with it. However, the Windows gem is now only 1.9 -- I couldn't get the fat binaries to build (opening a ticket on rake-compiler now), but since 1.8 is EOL'd, I'm not that concerned about dropping support for it.

@tmm1
Copy link
Collaborator

tmm1 commented Jul 5, 2013

Yea, the process is kind of a pain. Thanks again for struggling through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants