New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle uploading/unpacking taking forever #273
Comments
Update: I tried to upload the bundle on Codalab V1.5 (codalab.org) and it is working well. |
It looks like the problem was due to this line in the yaml: # remove me to fix bundle unpacking
competition_docker_image: '' Was this generated by v1.5 dumps? Pushing some code in a new branch that makes this error clearer |
…ll exceptions so unpacking hopefully doesn't hang forever
Thank you for your answer. Bundle are not supposed to be backward compatible? If no, we should have a script converting from V1.5 yaml to V2 yaml file. |
This happens transparently if you upload a v1.5 bundle. Was this bundle generated by v1.5 dumps? Trying to understand where the blank argument came from. |
It worked! Now I still have another not working bundle. I corrected the This one is a competition with 2 tasks (therefore 2 scores). Maybe this is linked to the issue. Here is the bundle: |
I am not sure. I wrote this yaml file by hand from another example. Maybe the previous example had this argument and I just removed the content inside the quotation mark. Or maybe I took it from a dump and made changes. |
Got it, since it works on V1.5 we'll make blank |
OK that's perfect. For the "Chems challenge bundle", the error comes from something else. |
* fixes #273, reports validation errors to the frontend; also catches all exceptions so unpacking hopefully doesn't hang forever * handle blank docker images * generates a nicer error message for nested YAML problems, i.e. pages['content'] errors * handle all falsy competition_docker_images
Still not able to upload the Chems challenge bundle. |
I've just tried another bundle that works on Codalab V1 but fails on Codalab V2 (also with multiple scores). Also, I had a bundle failing in both versions but in Codalab V1 I had an error message while in Codalab V2 I just have this infinitely long unpacking. |
I will look at implementing a fix for the fact that you aren't getting an error message for this bundle. The error I have found is that the |
Thank you very much for your help. I'll try this as soon as possible. As for the previous error in this thread (the empty field in yaml file), empty HTML pages didn't cause the bundle to fail in Codalab V1. For convenience and back compatibility, maybe empty HTML files should be handled.
Indeed, error message are crucial for debugging bundles. |
This should be fixed on the server now. |
Indeed it works, thank you very much. I can now upload the Chems bundle. The last one is Heart Attack challenge bundle. As always, the unpacking doesn't finish so I don't have an error message. This competition should be very close to "Chems" so I don't see why it isn't working. |
This is because your While i do not believe it is possible to engineer a solution that will be able to report all of these kinds of edge case bugs to users, I have some ideas I can discuss with Eric to at least prevent the "hanging" of the unpacking step. Even if the best error we can give is, "Something appears to be wrong with your bundle", I think that will be a better solution than just letting it "unpack" indefinitely. |
Apologies. My mistake, not sure how I must have added that space at the begging of the file... I do not have credentials to log in to the production server to look at logs there so I am limited in my debugging until tomorrow when I can talk w/ eric. However, if I were to guess, can you try removing the blank competition docker image line? I know this was an issue that was fixed in an earlier commit, but it is possible that was reverted by our most recent patch, fixing blank page content. If this does work, I should be able to have this fixed for real early tomorrow. |
Awesome, everything works now. Thank you for your efficiency! |
I'm trying to upload the following bundle to Codalab V2 (prod LRI instance):
Mortality challenge bundle.
The uploading seems to work but then the unpacking step never finishes.
The text was updated successfully, but these errors were encountered: