Added adapt features for v1.8 bundle #494
Conversation
| @@ -92,6 +92,8 @@ def replace_legacy_metadata_command(command, kind, is_scoring, ingestion_only_du | |||
| ('$hidden', '/app/input/ref'), | |||
| ('$shared', '/app/shared'), | |||
| ('$submission_program', '/app/ingested_program'), | |||
| ('$tmp', '/app/output'), | |||
| ('$predictions', '/app/input/res' if is_scoring else '/app/output'), | |||
There was a problem hiding this comment.
hmm, can you add a label to this like # v1.8 compatibility so it's a bit less confusing why there are duplicates?
| Determine if the current version is 1.8 | ||
| :return: | ||
| """ | ||
| for index, phase in enumerate(phases): |
There was a problem hiding this comment.
more pythonic to use any() probably?
return any(p.get('is_parallel_parent') or p.get('parent_phasenumber') for p in phases)
|
we should also add a v1.8 bundle to the functional tests, checkout this code.. Competition creation: Submission creation: Where to put test files: |
i already add it, trying to fix some test failure ~ |
|
Are you still working on getting these tests working? |
Logan-Ruf
changed the title
ckcollab
changed the title
Yes sir |
AuroraLauu
changed the title
|
@ckcollab hi Eric, CI error is being fixed |
|
Is this ready for review now, CI appears to be passing? |
That's awesome, please review it, tyvm!!! |
Template
This is a template. While not all sections are necessary, depending on the size and complexity of the PR,
more information is better.
@ mention of reviewers
@ckcollab @dde6khkg
...
A brief description of the purpose of the changes contained in this PR.
...
Added adaptation of v1.8 bundle.
Issues this PR resolves
...
enabled v18 bundle create competition and submit solution curr
Known issues to be addressed in a separate PR
...
A checklist for hand testing
Any relevant files for testing
link to any relevant files (or drag and drop into github)
Misc. comments
...
Checklist