Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

CPP PDF & Evaluation sheet issues #23

Open
3 tasks
W2Wizard opened this issue Sep 1, 2022 · 5 comments
Open
3 tasks

CPP PDF & Evaluation sheet issues #23

W2Wizard opened this issue Sep 1, 2022 · 5 comments
Assignees
Labels
Core Issues is regarding Core curriculum Scale Issue is in the scale (eval sheet) Subject Issue is in the subject

Comments

@W2Wizard
Copy link
Contributor

W2Wizard commented Sep 1, 2022

This is a pinned issue to track and discuss all the issues regarding the CPP evaluation sheets.

Simply state below what is bad or needs to be addressed!

Issues:

  • CPP 02, EX02: Moulinette does not test for values from 91 - 96, letting you pass if you simply check if the char is between 65 and 123
  • CPP 05, Page 8: Stupid typo "... higher or egal ...". Should be 'equal' not 'egal'
  • CPP 07 EX01: the subject says 'The third one is a function that will be call on every element of the array.' it's unclear what the exact type of that function should be. Should it return something? Should it be able to change an element in place?
@W2Wizard W2Wizard added the Core Issues is regarding Core curriculum label Sep 1, 2022
@W2Wizard W2Wizard self-assigned this Sep 1, 2022
@W2Wizard W2Wizard pinned this issue Sep 1, 2022
@W2Wizard W2Wizard changed the title CPP Evaluation sheet issues CPP PDF & Evaluation sheet issues Sep 1, 2022
@joppiesaus
Copy link

CPP 05, page 11 paragraph 2 final sentence:

It return a pointer to a Form object (whose name is the one passed as parameter)
whose target will be initialized to the second parameter

return should be returns, or something like that

@W2Wizard W2Wizard added Subject Issue is in the subject Scale Issue is in the scale (eval sheet) labels Sep 1, 2022
@joppiesaus
Copy link

CPP 03 page 5 last paragraph first sentence:

When ClapTrack attacks, it causes its target to lose hit points. (...)

ClapTrack should be ClapTrap. Also, the target is a string, and therefore cannot be attacked. It should probably be rewritten in order to accept a ClapTrap, but that's likely way out of scope.

@joppiesaus
Copy link

CPP 07 evalsheet contains code blocks you have to copy, but the code is malformed and miss definitions.

@DutChen18
Copy link

CPP 00 page 6

You’re free to design the classes as you like but keep in mind that
anything that will always be used inside a class is private, and that anything that can be
used outside a class is public.

Suggests that your members can be public if you can justify it. But the eval sheet requires them to be private anyways.
Also the question of whether your class members are private or not is a slider for some reason.

@bsomers42
Copy link

bsomers42 commented Feb 1, 2023

CPP 05 page 10:

Lastly, add the executeForm(Form const & form) member function to the Bureaucrat. It must attempt to execute the form.

The eval sheet asks for executeForm(AForm const & form) (Difference: Form vs AForm)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core Issues is regarding Core curriculum Scale Issue is in the scale (eval sheet) Subject Issue is in the subject
Projects
None yet
Development

No branches or pull requests

4 participants