Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions raised during request processing will not always be caught and returned as a 500 error #24

Closed
coddingtonbear opened this issue May 29, 2022 · 1 comment

Comments

@coddingtonbear
Copy link
Owner

coddingtonbear commented May 29, 2022

An error report was received from @kaiiiz in #23:

I notice a related issue, for the PUT /vault/{filename} endpoint, if the specified folder in the path doesn't exist, the server will hang forever. (e.g. filename = c/d.md and folder c doesn't exist)

image

What I expected to get from the server response:

It should return 405 Bad Request or create the nested folder structure before creating the new file (maybe an optional parameter for this functionality?).

Originally posted by @kaiiiz in #23 (comment)

@coddingtonbear
Copy link
Owner Author

This was fixed (in that requests can no longer hang and will return a 500 error for unhandled errors) via 1f67f2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant