QA Report #182
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Low
Shadowed
nonces
variablenonces
is defined in ERC20Datahttps://github.com/Plex-Engineer/zeroswap/blob/03507a80322112f4f3c723fc68bed0f138702836/contracts/SushiToken.sol#L120
Use require instead of assert
Assert false should not be triggered in production as it will consume all remaining gas, use require instead.
Multiple pragma used
Consider to use a single pragma config
Non-Critical
Typo
https://github.com/Plex-Engineer/lending-market/blob/ab31a612be354e252d72faead63d86b844172761/contracts/CToken.sol#L290
efore -> before
Hardcoded address
https://github.com/Plex-Engineer/lending-market/blob/2d423c7c3f62d65182d802deb99cc7bba4e057fd/contracts/Governance/GovernorBravoDelegate.sol#L28
The text was updated successfully, but these errors were encountered: