Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #264

Open
code423n4 opened this issue Jun 21, 2022 · 1 comment
Open

QA Report #264

code423n4 opened this issue Jun 21, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

FINDINGS

TYPO

File: BaseV1-periphery.sol line 463

        require(token.code.length > 0, "token code length faialure");

faialure instead of failure

Open TODO left in the code

File: Comptroller.sol line 1232

        // TODO: Don't distribute supplier COMP if the user is not in the supplier market.

Lock pragmas to specific compiler version

Contracts should be deployed with the same compiler version and flags that they have been tested the most with. Locking the pragma helps ensure that contracts do not accidentally get deployed using, for example, the latest compiler which may have higher risks of undiscovered bugs. Contracts may also be deployed by others and the pragma indicates the compiler version intended by the original authors.

File:Proposal-Store.sol line 3

pragma solidity ^0.8.0;

File:WETH.sol line 1
File: Comptroller.sol line 2
File: CNote.sol line 1

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 21, 2022
code423n4 added a commit that referenced this issue Jun 21, 2022
@GalloDaSballo
Copy link
Collaborator

TYPO

NC

Open TODO left in the code

NC

Lock pragmas to specific compiler version

3 NC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

2 participants