Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NAZ-M9] isMinter Can Be Granted By The Deployer Of StableToken And Mint/Burn Arbitrary Amount Of Tokens #598

Closed
code423n4 opened this issue Dec 16, 2022 · 6 comments
Closed

[NAZ-M9] isMinter Can Be Granted By The Deployer Of StableToken And Mint/Burn Arbitrary Amount Of Tokens #598

code423n4 opened this issue Dec 16, 2022 · 6 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-377 unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-12-tigris/blob/main/contracts/StableToken.sol#L9
https://github.com/code-423n4/2022-12-tigris/blob/main/contracts/StableToken.sol#L38

Vulnerability details

Impact

If the private key of the deployer or an address in the isMinter mapping is compromised, the attacker will be able to mint/burn an unlimited amount of tigUSD tokens.

Tools Used

Manual Review

Recommended Mitigation Steps

Consider removing the isMinter mapping making tigUSD only mintable by the owner, and make the stableToken.sol contract to be the owner and therefore the only minter.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Dec 16, 2022
@GalloDaSballo
Copy link

Basically the same as vault rug, but missing further detail

@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Dec 23, 2022
@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as unsatisfactory:
Invalid

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as duplicate of #383

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as duplicate of #377

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as satisfactory

@c4-judge c4-judge added satisfactory satisfies C4 submission criteria; eligible for awards unsatisfactory does not satisfy C4 submission criteria; not eligible for awards and removed unsatisfactory does not satisfy C4 submission criteria; not eligible for awards satisfactory satisfies C4 submission criteria; eligible for awards labels Jan 22, 2023
@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as unsatisfactory:
Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-377 unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @c4-judge