Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> M from #254 [1674418824740] #669

Closed
c4-judge opened this issue Jan 22, 2023 · 2 comments
Closed

Upgraded Q -> M from #254 [1674418824740] #669

c4-judge opened this issue Jan 22, 2023 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-198 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-judge
Copy link
Contributor

Judge has assessed an item in Issue #254 as M risk. The relevant finding follows:

03: Lock.claimGovFees() will revert with tokens that have approve race condition protection
Some tokens only allow you to approve a new value if the current allowance is set to zero, e.g. USDT.

This is not an issue right now on Polygon or Arbitrum. But, stablecoin contracts on those networks are upgradable and migth change. Also, if you decide to deploy the protocol to other networks, you might encounter this problem.
@c4-judge c4-judge added the 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value label Jan 22, 2023
@c4-judge
Copy link
Contributor Author

GalloDaSballo marked the issue as duplicate of #198

@c4-judge c4-judge added duplicate-198 satisfactory satisfies C4 submission criteria; eligible for awards labels Jan 22, 2023
@c4-judge
Copy link
Contributor Author

GalloDaSballo marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-198 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c4-judge