Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove Handles from Graph #6040

Closed
wants to merge 21 commits into from

Conversation

joshuashort
Copy link
Contributor

No description provided.

@joshuashort joshuashort linked an issue Dec 13, 2022 that may be closed by this pull request
4 tasks
@joshuashort joshuashort changed the title Remove Handles from Graph WIP: Remove Handles from Graph Dec 13, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 13, 2022

✅ code4rena.com deploy preview ready

@hannahtuttle hannahtuttle self-assigned this Dec 13, 2022
@hannahtuttle
Copy link
Contributor

hannahtuttle commented Dec 13, 2022

Just a Quick update: I have a netlify function that pulls in all the data from _data/handles and returns an array of handles and I started replacing the call for judge-application.js . There are 4 places that I have seen that will need to be updated.

  • create netlify function for handles
  • judge-application.js
  • manage-team.tsx
  • register-team.tsx
  • register.tsx

Edit: the handle query that was being used in the judge-application was not being used. It was being passed down to widgets => widget, but the handle options are not being applied to anything. The handle that is used for the judgeApplication function is being grabbed from the current logged in user. So I remove the logic from there.

@hannahtuttle
Copy link
Contributor

@joshuashort I need to take a break on this, but I will get back to it this evening. I am working on the register.tsx. But I did add my changes here so you can see the progress here.

@joshuashort
Copy link
Contributor Author

@joshuashort I need to take a break on this, but I will get back to it this evening. I am working on the register.tsx. But I did add my changes here so you can see the progress here.

have you seen the existing get-team and get-user functions? Can those be used?

@hannahtuttle
Copy link
Contributor

have you seen the existing get-team and get-user functions? Can those be used?

Yes, I did see that and I plan to use the get-team function and possibly the get-user functions as I need the team for at register.tsx but I haven't looked through register-team or manage-team yet but I imagine I will need it for those as well. I will be back on later tonight my time and should get another good chunk of this done then.

@joshuashort
Copy link
Contributor Author

have you seen the existing get-team and get-user functions? Can those be used?

Yes, I did see that and I plan to use the get-team function and possibly the get-user functions as I need the team for at register.tsx but I haven't looked through register-team or manage-team yet but I imagine I will need it for those as well. I will be back on later tonight my time and should get another good chunk of this done then.

Nice -- thanks!

(and good find on the removable judge-application use!)

@hannahtuttle
Copy link
Contributor

@joshuashort I added that file in here, could you review these changes and then could we meet to talk about the next phase of these changes?

@hannahtuttle hannahtuttle added Stand by depends on other factors and removed WIP labels Jan 3, 2023
@Simon-Busch Simon-Busch self-requested a review January 24, 2023 10:00
@Simon-Busch Simon-Busch removed the Stand by depends on other factors label Jan 24, 2023
@natevw
Copy link
Contributor

natevw commented Mar 9, 2023

Adding @captainmangoC4 as an "assignee" here too (whatever that means exactly wrt to a PR?) just since it's possible they might be revisiting a lot of things related to handles during some upcoming function migration work.

@SamusElderg
Copy link
Collaborator

Closing stale PR

@SamusElderg SamusElderg closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Remove Handles from Graph
6 participants