Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC compliance on non-EVM rollups and blockchains (e.g. Starknet) #150

Open
ustas-eth opened this issue Feb 29, 2024 · 1 comment
Open

Comments

@ustas-eth
Copy link

See the discussion below this finding:
code-423n4/2024-01-opus-findings#17

It is a good practice on Starknet, for example, to use different popular standards like ERC20 for obvious reasons. But there are conflicts with the Cairo language.

E.g., the function names should be written in snake_case, while in Solidity (and the ERCs), we use camelCase. One way to resolve the issue is to duplicate the functions and create both snake_case and camelCase versions.

There can be other problems as well, and this can apply not only to Starknet.

Anyway, the point is that it is definitely not good to mention an ERC in the docs and contracts of a project and leave the question of compliance open.

So, I suggest thinking a little and coming up with some decisions on how to evaluate findings like the one above in the contests. Should we adhere to the existing rules (which is understandable because the project explicitly mentions the ERCs) or apply less strict ones (which can be technically justified)?

@bytes032
Copy link

My take is that projects should explicitly mention the ERCs and the contracts that should comply with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants