about Code Structure (and auto-testing/Selenium/Github Actions and so on)

[ImprovedTube]

hi guys, separating this topic from issue thread. Should be a wikipage / mentioned in the readme?
@talks2much commented 12 days ago
"

YouTube "Like" and "Dislike" shortcuts no longer... (YouTube might've updated something on their end). This has been going on...

We should definitely setup tests with GitHub action to test all YouTube features every day to fix them in time, just like node-ytdl-core did it.

@ImprovedTube What do you think about TypeScript & ES2018+ refactor? This codebase might have some bugs that rly hard to detect due types overlapping.
"

---

victor-savinov commented 11 days ago

Logging.

The structure of ImprovedTube code is as simple as possible, you don't need to have error logs to fix a bug. Bug fix algorithm:

1. Find a feature that doesn't work
2. Check the code (youtube-scripts.js -> ImprovedTube.featureName)
3. Check YouTube (most of the problems are due to YouTube changing the names of elements in the DOM)
4. Fix the bug

Refactor.

ImprovedTube.shortcuts - is already a refactor . The idea behind the ImprovedTube structure is "block-based": all the feature code is stored in the ImprovedTube.featureName. Your request complicates the code:

• current version: ImprovedTube -> shortcuts -> start -> features -> shortcut_like_shortcut
• good version: ImprovedTube -> shortcutLike
• your version: ImprovedTube -> shortcuts -> start -> features -> shortcut_like_shortcut -> pressButton -> buttonsSelectors

TypeScript.

Most people use only JavaScript. TypeScript splits the community, I'm not sure if this improve the developer experience. It also requires compilation.