Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player control bar disappears when hover cursor over it #1976

Closed
xeophyte opened this issue Jan 31, 2024 · 12 comments
Closed

Player control bar disappears when hover cursor over it #1976

xeophyte opened this issue Jan 31, 2024 · 12 comments
Assignees

Comments

@xeophyte
Copy link

xeophyte commented Jan 31, 2024

Bug Report:

BUG: "Hide player controls bar" "When paused" not working
HOW:

  1. go to settings/appearance/player -> set "Hide player controls bar" to "When paused"
  2. hover cursor over player control bar for a while when playing/paused and don't move it

⚬ ImprovedTube Version: 4.615
⚬ Browser: Vivaldi 6.6.3249.4 (64-bit)
⚬ Settings: improvedtube.json
⚬ OS: Win 11
⚬ Device: PC

@xeophyte xeophyte added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jan 31, 2024
@ImprovedTube
Copy link
Member

hi! looks like you you want it hidden when paused

#1572

@xeophyte
Copy link
Author

xeophyte commented Feb 1, 2024

Yes, but when the cursor hover over it, it should not hide regardless if the video is paused or playing, so it should react the same as original YT (without extension). Now, with "Hide player controls bar" option set to "When paused", it is difficult to use the progress bar.

@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

This is standard YT behavior. YT does same thing without extension

@raszpl raszpl removed the Bug Bug or required update after YouTube changes label Mar 4, 2024
@xeophyte
Copy link
Author

xeophyte commented Mar 4, 2024

No, without extension it doesn't disappear:
vivaldi - 2024 03 04_12 30 50

@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

logged into YT? I have not logged standalone chrome installed with no extensions and in that stock not logged in Chrome status disappears after 2 seconds.
Now the funny thing is It was disappearing for me in Vivaldi + logged into YT + improvetube 7 hours ago, but it doesnt now when hovering over Pause/Next or seek bar :D. Even with improvetube disabled it still doesnt disappear. Maybe uBlock does the magic here?

@xeophyte
Copy link
Author

xeophyte commented Mar 4, 2024

Yes, logged into YT, tried witohut any other extensions and it still disappears. But then it's strange because when I enable other extensions back, control bar doesn't disappear... until I pause/play or use seek bar, it starts to disappear again.

@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

all in all it doesnt appear to be improvetube fault, can we agree its not a improvetube bug?

@xeophyte
Copy link
Author

xeophyte commented Mar 4, 2024

But this still occurs only with this extension. Check with my settings, refresh the YT page and click pause/seek bar, then hover over the scroll bar/play button
improvedtube.json

@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

The fact seekbar doesnt disappear for me without any extensions tells me this is YouTube screwing with users, you might be getting server one of google experimental UI versions

@xeophyte
Copy link
Author

xeophyte commented Mar 4, 2024

I'm not in the experimental program because the bar doesn't disappear without IYT extension with "Hide player controls bar" option set to "When paused".
Set "Hide player controls bar" option to "When paused" and then click pause - the bar will disappear.

@raszpl
Copy link
Contributor

raszpl commented Jun 15, 2024

I had opportunity to look at playerControls() #2381 in more details.
Default YT with no extensions 'hover cursor over player control bar' disappears if I hover cursor over upper edge of the seek line :0 thats where the confusion came from. As long as tip of finger icon is right on top of the line it stays, if it goes one pixel over it will still render thumbnail, but disappears after 1-2 seconds.

TLDR there are two elements

<div class="ytp-progress-bar-padding"></div>
<div class="ytp-progress-list">...</div>

first one is way thicker, both trigger thumbnail display, when testing I was hovering over the thicker one
Fix: #2382

@raszpl raszpl self-assigned this Jun 15, 2024
@raszpl raszpl removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jun 15, 2024
@xeophyte
Copy link
Author

Looks like fixed to me in 4.1007.

@raszpl raszpl closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants