Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening in new tab doesn't apply settings (playback speed, fullscreen, autoplay) - clearing cookies fixes it for a time #2136

Open
Jerrk opened this issue Mar 31, 2024 · 5 comments
Labels
Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Jerrk
Copy link

Jerrk commented Mar 31, 2024

1. Bug Report:

BUG:
When opening a video in a new tab, it appears none of the settings in the extension will apply. But if i then from that video navigate to a different video, the settings will apply.

It will also apply the settings if i press i to open the miniplayer, and then press i again to go back to the full video player.
So it appears that the settings will apply when the player is "reloaded"?

⚬ Browser:
Chromium Version 123.0.6312.90

HOW:
Clear cookies, login, play a certain amount of videos (not sure about this step here because it sometimes happens after a couple of days and sometimes it happens the same day), open a video in a new tab, see the issue, clear cookies, login, the issue is gone.

⚬ Does the bug not happen when you log out of YouTube?
It appears that logging out does indeed fix this issue, so it appears to be tied to your account? maybe after x amount of videos watched on an account they load the player differently?
ctrl+u gave me this:
ctrl+u.txt

It may be related to #1851 #2012 and #1856

@Jerrk Jerrk added Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Mar 31, 2024
@raszpl
Copy link
Contributor

raszpl commented Apr 6, 2024

I think its a deeper failure of the extension to initialize
I just caught something similar when opening video from a link on another site, extension failed to load properly:
bad
page refresh and everything was fine again:
good

sadly those pictures are useless for debugging, but it was teh only difference I could spot, console was clear of errors :(. I added some console.logs to both extension/web-accessible core/init.js so next time this happens I can at least see where the problem was

@Jerrk
Copy link
Author

Jerrk commented Apr 7, 2024

For me a page refresh does not fix the issue and load the extension in this situation.

@raszpl
Copy link
Contributor

raszpl commented Apr 7, 2024

This extension dosnt use cookies for at all, so clearing cookies will have no influence over the way it works. What does change is you are being logged out of YT without cookies. Its possible YT is forcing you into some new experiment. I dont even know how to check for that, @ImprovedTube will know more.

@Jerrk
Copy link
Author

Jerrk commented Apr 7, 2024

yes that is my guess as well

@CodeClimberNT
Copy link

I'm adding myself to this issue.
I find also the hamburger menu in the player not showing when opening a video in a new tab and also an annoying bug with the short when opened (the audio is played but an overlay to show that an user input is required to start the video resulting in a strange experience), as before, in a new tab. All the problem are fixed when (for a video) open a new one in the same tab and come back using the browser navigation function, and for the shorts video scroll to load the next and go back up to load again the previous one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants