Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask Vivaldi to review their sidePanel implementation. #2293

Closed
nonchip opened this issue May 21, 2024 · 16 comments
Closed

ask Vivaldi to review their sidePanel implementation. #2293

nonchip opened this issue May 21, 2024 · 16 comments

Comments

@nonchip
Copy link

nonchip commented May 21, 2024

1. Bug Report:

  • BUG:
    image

    • Browser: vivaldi
    • HOW: start browser, wait ~5mins, the popup thingy adds itself as a webpanel and opens with 0 interaction. can be removed until next browser start. is a different instance (contains same settings/etc but no "runtime" stuff like which menu was open) from the actual popup that shows if i press the button.

More:

  • Expected /preferred behavior: to not open anything unless i click the button.
  • ImprovedTube Version: [this is NOT written at the top thanks to the most useless searchbar ever, but at least at the top of the specific settings submenu] 4.936
  • Tested alone without other YouTube extensions or in incognito mode? without other extensions / even on fresh profile does the same; incognito mode obviously won't let me test because you have to load a profile to restart the browser.
  • My Settings: [again, the instructions lie, "backup&reset" is a submenu of settings, not "..."]
    improvedtube.json

- DOM: - OS: - Device:

yeah all of that is N/A and next time your browser extension has to ask for "Device" i'd instead suggest learning what a browser is.

@nonchip nonchip added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 21, 2024
@demom3b
Copy link

demom3b commented May 21, 2024

Yeah, it's a Vivaldi issue, I already reported this to vivaldi, waiting on them to fix it. You can try other extensions that support the side penal, they will popup right after you install them without asking for permission.

@nonchip
Copy link
Author

nonchip commented May 21, 2024

You can try other extensions that support the side penal, they will popup right after you install them without asking for permission.

the problem there is that i have other extensions that support the sidepanel and but don't do that; and i disabled the side panel feature in this extension and it still does that...

@tuangd
Copy link

tuangd commented May 21, 2024

I have the same issue. On Vivaldi also.

edit: It's super annoying though until this resolve I will have to live without the IYT extension.

@xeophyte
Copy link

Same here. This appeared after one of the last updates, but I don't know if it was after the Vivaldi update (I use snapshots) or the IYT extension.

@demom3b
Copy link

demom3b commented May 21, 2024

i have other extensions that support the sidepanel and but don't do that

Which one, let me try it.

@YmerejO42
Copy link

YmerejO42 commented May 21, 2024

Same here. This appeared after one of the last updates, but I don't know if it was after the Vivaldi update (I use snapshots) or the IYT extension.

I do NOT use snapshots and it started about a week ago. It is SUPER annoying, to the extent I was tempted to report the addon for abuse.

@nonchip

This comment was marked as spam.

@ImprovedTube ImprovedTube removed the Bug Bug or required update after YouTube changes label May 21, 2024
@ImprovedTube ImprovedTube changed the title stop adding your ui popup thing as a webpanel EVERY SINGLE TIME I START THE BROWSER ask Vivaldi to review their sidePanel implementation. May 21, 2024
@nonchip

This comment was marked as spam.

@nonchip nonchip changed the title ask Vivaldi to review their sidePanel implementation. fix sidePanel API usage. May 21, 2024
@ImprovedTube ImprovedTube removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 21, 2024
@ImprovedTube ImprovedTube changed the title fix sidePanel API usage. ask Vivaldi to review their sidePanel implementation. May 21, 2024
@ImprovedTube
Copy link
Member

Yeah, it's a Vivaldi issue, I already reported this to vivaldi, waiting on them to fix it. You can try other extensions that support the side penal, they will popup right after you install them without asking for permission.

in public? did they answer? @demom3b


For now you (or we) can also remove the side-panel declaration from our manifest.json. But generally it feels wrong that we keep doing things only for Vivaldi

(#2288) @tuangd @xeophyte @kolumdium @Gobbr The sidepanel was removed for now from Chrome Webstore in favor of Vivaldi ( v4.938, pending) (Even we dont know if 1 in 1000 of our Users also use Vivaldi.)


"The side panel can be set initially from the default_path property in the side_panel key of the manifest to display the same side panel on every site."

not vivaldi's fault
blaming of the vivaldi team

"the same" as in "not a different one"
!== "must always/randomly appear" ( so maybe you discovered Vivaldi's big misunderstanding? ) (and this is how you could open a sidepanel programmatically https://developer.chrome.com/docs/extensions/reference/api/sidePanel#user-interaction, not through the manifest.json & not mentioned at first) @nonchip

PS who wrote that?!

(this is the toggle improvedTubeSidePanel, at ImprovedTube: General)

@xeophyte
Copy link

xeophyte commented May 21, 2024

Even we dont know if 1 in 1000 of our Users also use Vivaldi.

You may have many more users using Vivaldi than you think because most Vivaldi browsers identify themselves as Chrome.
https://vivaldi.com/blog/user-agent-changes/
https://www.zdnet.com/article/vivaldi-to-change-user-agent-string-to-chrome-due-to-unfair-blocking/
For example, in my Vivaldi's settings there is this User Agent set by default as Google Chrome:

image

So unfortunately, the official browser popularity statistics do not show the true result.

@ImprovedTube
Copy link
Member

hi! :) @xeophyte. Vivaldi actually got only 0.0x% market share, yet there might be significant correlation in our user-bases...

@nonchip

This comment was marked as spam.

@thangcuoi
Copy link

@nonchip I appreciate all the info you have present, trying to get this issue resolve, but maybe tone it down a little. You might not be aware that you are coming across as being very aggressive and abusive toward the dev/owner of this project who is putting their time and effort in for free.

Pushing too hard will more than likely results in the dev stop listening all together.

If you have the capability, consider writing the fix yourself, or fork the project and merge the fix yourself.

For myself, I have switched to a similar extension. I might return when the issue is resolved.

@nonchip

This comment was marked as spam.

@nonchip nonchip changed the title ask Vivaldi to review their sidePanel implementation. fix sidepanel implementation that all of the chrome apidocs are *not* wrong about May 22, 2024
@code-charity code-charity deleted a comment from thangcuoi May 22, 2024
@ImprovedTube ImprovedTube changed the title fix sidepanel implementation that all of the chrome apidocs are *not* wrong about ask Vivaldi to review their sidePanel implementation. May 22, 2024
@ImprovedTube
Copy link
Member

@thangcuoi @nonchip @Gobbr. Side panel (on intentional click only), was undone (see version 4.938 in Chrome Webstore & #2288). Sometimes updates are pending for a while, keeping us from releasing other work and Chrome Webstore still doesn't allow to upload the next version already while the current one is pending(, which sometimes makes these decisions harder, to do something in favor of Vivaldi only, etc.(, which was one of the stranger feelings here a few times over the years, since maybe less than 1 in a million people actually use both Vivaldi and ImprovedTube)
screen


( As for making sure we had no bug in using the API, it can be efficient to watch the same "side_panel":{"default_path":"html/sidepanel.html" in other extensions, such as https://crxcavator.io/source/jdbnofccmhefkmjbkkdkfiicjkgofkdh/2.3.0?platform=Chrome
https://chromewebstore.google.com/detail/lesezeichenleiste/jdbnofccmhefkmjbkkdkfiicjkgofkdh
Besides that no manifest.json options are meant to cause such a bug.)

@nonchip

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants