Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track reasons for GitHub event errors in database #873

Closed
joshsmith opened this issue Aug 30, 2017 · 2 comments
Closed

Track reasons for GitHub event errors in database #873

joshsmith opened this issue Aug 30, 2017 · 2 comments

Comments

@joshsmith
Copy link
Contributor

Problem

For the milestoned action, which I don't believe is currently handled, our issue events result in an errored status. Although the returned error in Elixir may have :not_fully_implemented, this does not appear to be recorded in the database.

@joshsmith joshsmith added this to the GitHub integration milestone Aug 30, 2017
@begedin
Copy link
Contributor

begedin commented Aug 30, 2017

We don't really have a concept of milestones on our side, so I'm not sure what ought to be done here? Do we record an event with a special status and return an ok response, instead of erroring it out?

Maybe something like, processed_noop?

Do we just mark it as processed and be done with it?

The way I see it, we wont be going through old events once we support them anyway, since github doesn't work like that.

Presumably, if we start supporting a new github feature in the future, we will instead go through applicable records and do a manual background sync.

With that in mind, it may even make sense to mark the event as unsupported and be done with it.

@joshsmith
Copy link
Contributor Author

Yeah I think marking it as unsupported is really what we want. What I meant is that we get specific with why something "errored" in elixir itself but not in what we record to the database. For other errors we should also really keep track of the reason.

@joshsmith joshsmith changed the title Issue events error for milestoned action Track reasons for event errors in database Aug 30, 2017
@joshsmith joshsmith changed the title Track reasons for event errors in database Track reasons for GitHub event errors in database Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants