Skip to content

Commit

Permalink
Merge b65ad74 into fae1e70
Browse files Browse the repository at this point in the history
  • Loading branch information
maartenvanvliet committed Jun 10, 2019
2 parents fae1e70 + b65ad74 commit c2ae3a2
Showing 1 changed file with 17 additions and 3 deletions.
20 changes: 17 additions & 3 deletions lib/stripe/converter.ex
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,12 @@ defmodule Stripe.Converter do
@spec convert_value(any) :: any
defp convert_value(%{"object" => object_name} = value) when is_binary(object_name) do
case Enum.member?(@supported_objects, object_name) do
true -> convert_stripe_object(value)
false -> convert_map(value)
true ->
convert_stripe_object(value)

false ->
warn_unknown_object(value)
convert_map(value)
end
end

Expand Down Expand Up @@ -109,6 +113,16 @@ defmodule Stripe.Converter do
@spec convert_list(list) :: list
defp convert_list(list), do: list |> Enum.map(&convert_value/1)

if Mix.env() == "prod" do
defp warn_unknown_object(_), do: :ok
else
defp warn_unknown_object(%{"object" => object_name} = value) do
require Logger

Logger.warn("Unknown object received: #{object_name}")
end
end

if Mix.env() == "prod" do
defp check_for_extra_keys(_, _), do: :ok
else
Expand Down Expand Up @@ -140,7 +154,7 @@ defmodule Stripe.Converter do

details = "#{module_name}: #{inspect(extra_keys)}"
message = "Extra keys were received but ignored when converting #{details}"
Logger.debug(message)
Logger.warn(message)
end

:ok
Expand Down

0 comments on commit c2ae3a2

Please sign in to comment.