Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows redirect uri params #231

Merged
merged 1 commit into from May 25, 2017
Merged

Allows redirect uri params #231

merged 1 commit into from May 25, 2017

Conversation

jekku
Copy link
Contributor

@jekku jekku commented May 10, 2017

This allows usage of redirect uri in stripe connect url generator.

@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage increased (+0.2%) to 78.351% when pulling e0378d4 on jekku:redirect-uri-for-connect into 05ca35b on code-corps:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 78.351% when pulling 7dd3032 on jekku:redirect-uri-for-connect into 05ca35b on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 78.351% when pulling 7dd3032 on jekku:redirect-uri-for-connect into 05ca35b on code-corps:master.

@jekku
Copy link
Contributor Author

jekku commented May 22, 2017

Hi! Is anyone still maintaining this repository? :)

@begedin
Copy link
Contributor

begedin commented May 22, 2017

Hey @jekku I thought I posted a reply here, but I guess it failed somehow.

The repository is maintained, but the master branch is mostly frozen, with us working on the 2.0 branch, which is way ahead of the master, in features. That being said, I'm not sure 2.0 supports what you need, but if you could try and make the switch, and see how it works out for you, we would love to get this in there. Otherwise, we can get this merged for you into master.

@jekku
Copy link
Contributor Author

jekku commented May 22, 2017

Hi @begedin .

The project we're actually using this library in has some dependency locks due to other libraries with similar deps as StripityStripe:master. So I guess the latter option would be great! Thanks :)

@jekku
Copy link
Contributor Author

jekku commented May 22, 2017

This feature is also not in 2.0 so you could actually pull it in :) Redirect URI options for stripe connect are important (For separating ENV concerns by multiple callback urls) and are available in non elixir implementations. :D

@jekku
Copy link
Contributor Author

jekku commented May 23, 2017

Will wait on an update about this. Thanks so much @begedin :)

@joshsmith
Copy link
Contributor

Hi @jekku sorry for the long delay on this. Can you squash your commit down to one and then I'll happily merge and ship a version bump?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 78.351% when pulling 9226fa2 on jekku:redirect-uri-for-connect into 05ca35b on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 78.351% when pulling 9226fa2 on jekku:redirect-uri-for-connect into 05ca35b on code-corps:master.

@jekku
Copy link
Contributor Author

jekku commented May 24, 2017

@joshsmith updated with squashed commit. Sorry it took a while because we're probably in opposite timezones. :) There goes. Thank you so much!

@jekku
Copy link
Contributor Author

jekku commented May 25, 2017

Hi sorry for being so bothersome :)

@joshsmith joshsmith merged commit 1b6a71a into beam-community:master May 25, 2017
@joshsmith
Copy link
Contributor

@jekku far from a bother! Thanks for the ping. And for the PR!

Interested in contributing some other things around here?

@jekku
Copy link
Contributor Author

jekku commented May 26, 2017

@joshsmith if there are any! :) Sure.

@joshsmith
Copy link
Contributor

@jekku yes indeed, plenty! We've got a number of open issues around the 2.0 branch that could use some help to get to parity with the Stripe API itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants