Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SetupIntent #522

Merged
merged 7 commits into from Sep 7, 2019
Merged

Add support for SetupIntent #522

merged 7 commits into from Sep 7, 2019

Conversation

moomerman
Copy link
Contributor

@moomerman moomerman commented Jul 13, 2019

This PR adds support for the Stripe SetupIntent object.

  • Add SetupIntent module and tests
  • Update stripe-mock to latest version for /setup-intents endpoint support.

@coveralls
Copy link

coveralls commented Jul 13, 2019

Coverage Status

Coverage increased (+0.2%) to 88.456% when pulling d5c867b on moomerman:feature/setup-intents into ffef07d on code-corps:master.

@moomerman moomerman changed the title Add SetupIntent Add support for SetupIntent Jul 13, 2019
@moomerman moomerman marked this pull request as ready for review July 18, 2019 09:46
@snewcomer
Copy link
Collaborator

Tests are fixed! Mind merging in master?

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a quick review and everything looks pretty close to good!

lib/stripe/core_resources/setup_intent.ex Show resolved Hide resolved
lib/stripe/core_resources/setup_intent.ex Show resolved Hide resolved
lib/stripe/core_resources/setup_intent.ex Show resolved Hide resolved
lib/stripe/core_resources/setup_intent.ex Show resolved Hide resolved
@mtoeltsch
Copy link

Hi guys,
quick comment:
The Stripe.Subscription is missing the field 'pending_setup_intent'.

@moomerman
Copy link
Contributor Author

Thanks, I'll have look at these. It seems they're still developing it, the list option wasn't there when I implemented it!

@snewcomer
Copy link
Collaborator

@moomerman Let me know if you have time to round this one out this week! Looking to release 2.5 by the end of the week.

@doughsay
Copy link

doughsay commented Sep 4, 2019

Hi everyone, what are the chances we can get this included soon? The EU SCA deadline is fast approaching on September 14th, and we need to use the SetupIntents API to properly support it. 😅 For now, I'm going to attempt to use the branch directly, hoping it works ok!

Thanks for all the hard work on this!

@maartenvanvliet
Copy link
Member

For SCA this may also be needed #539

Feel free to cherry-pick that commit into this branch before merging.

@moomerman
Copy link
Contributor Author

moomerman commented Sep 5, 2019

@snewcomer sorry was away last week so didn't get a chance to make v2.5.

I've addressed everything now, have left as separate commits for review but let me know if it's good and I'll squash them.

I wasn't sure about the last commit Add type for payment_method_options
d5c867b - whether this is necessary of just use a map.

@snewcomer
Copy link
Collaborator

What an amazing PR. Thank you thank you!

@snewcomer snewcomer merged commit fa4ba63 into beam-community:master Sep 7, 2019
@snewcomer
Copy link
Collaborator

2.6 was released! Thank you @maartenvanvliet and @moomerman! Amazing work

@moomerman moomerman deleted the feature/setup-intents branch September 7, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants