Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stripe Test Clocks #723

Merged
merged 10 commits into from
Aug 21, 2022

Conversation

stefanluptak
Copy link
Contributor

Stripe added Test Clocks few weeks ago.

It could be extremely helpful with testing complex billing scenarios.

This is my first PR on this repository. Please, take a look and let me know what to improve.

There's one test failing: test/stripe/terminal/location_test.exs:39
I don't know how to fix it, so any help would be appreciated. :-)

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one failing test with the Stripe upgrade but otherwise looks great! Do you have time to try and fix the test? Otherwise I can merge and fix later

Update updates location (Stripe.Terminal.LocationTest)

@snewcomer snewcomer merged commit 3847e39 into beam-community:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants